lib

commit cc9a3940269b1b8614089e7f4ef7652b1e84fd8c
parent 896bce641dc9f2c31ca4f016a6447a322f679b6d
Author: triesap <tyson@radroots.org>
Date:   Tue,  7 Apr 2026 22:34:56 +0000

vault: normalize string conversion in secret backends

- replace `ToString` calls with explicit `String::from` and `format!`
- keep no-std and std `radroots-secret-vault` builds aligned
- remove warning-level drift from the closing verification matrix
- preserve host-vault and encrypted-file behavior unchanged

Diffstat:
M
crates/secret-vault/src/vault.rs
 | 
16
++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/crates/secret-vault/src/vault.rs b/crates/secret-vault/src/vault.rs
@@ -1,4 +1,4 @@
-use alloc::string::{String, ToString};
+use alloc::{format, string::String};
 
 use crate::error::RadrootsSecretVaultAccessError;
 
@@ -31,7 +31,7 @@ impl RadrootsSecretVault for RadrootsSecretVaultMemory {
             .entries
             .write()
             .map_err(|_| RadrootsSecretVaultAccessError::Backend("memory vault poisoned".into()))?;
-        guard.insert(slot.to_string(), secret.to_string());
+        guard.insert(String::from(slot), String::from(secret));
         Ok(())
     }
 
@@ -80,28 +80,28 @@ impl Default for RadrootsSecretVaultOsKeyring {
 impl RadrootsSecretVault for RadrootsSecretVaultOsKeyring {
     fn store_secret(&self, slot: &str, secret: &str) -> Result<(), RadrootsSecretVaultAccessError> {
         let entry = keyring::Entry::new(self.service_name.as_str(), slot)
-            .map_err(|source| RadrootsSecretVaultAccessError::Backend(source.to_string()))?;
+            .map_err(|source| RadrootsSecretVaultAccessError::Backend(format!("{source}")))?;
         entry
             .set_password(secret)
-            .map_err(|source| RadrootsSecretVaultAccessError::Backend(source.to_string()))
+            .map_err(|source| RadrootsSecretVaultAccessError::Backend(format!("{source}")))
     }
 
     fn load_secret(&self, slot: &str) -> Result<Option<String>, RadrootsSecretVaultAccessError> {
         let entry = keyring::Entry::new(self.service_name.as_str(), slot)
-            .map_err(|source| RadrootsSecretVaultAccessError::Backend(source.to_string()))?;
+            .map_err(|source| RadrootsSecretVaultAccessError::Backend(format!("{source}")))?;
         match entry.get_password() {
             Ok(secret) => Ok(Some(secret)),
             Err(keyring::Error::NoEntry) => Ok(None),
-            Err(source) => Err(RadrootsSecretVaultAccessError::Backend(source.to_string())),
+            Err(source) => Err(RadrootsSecretVaultAccessError::Backend(format!("{source}"))),
         }
     }
 
     fn remove_secret(&self, slot: &str) -> Result<(), RadrootsSecretVaultAccessError> {
         let entry = keyring::Entry::new(self.service_name.as_str(), slot)
-            .map_err(|source| RadrootsSecretVaultAccessError::Backend(source.to_string()))?;
+            .map_err(|source| RadrootsSecretVaultAccessError::Backend(format!("{source}")))?;
         match entry.delete_credential() {
             Ok(_) | Err(keyring::Error::NoEntry) => Ok(()),
-            Err(source) => Err(RadrootsSecretVaultAccessError::Backend(source.to_string())),
+            Err(source) => Err(RadrootsSecretVaultAccessError::Backend(format!("{source}"))),
         }
     }
 }