lib

commit 366a596afec3f39bae98a25943da096b91d6ac43
parent 825e8e043f7b68ba869a05ee6553dd8f6483999b
Author: triesap <tyson@radroots.org>
Date:   Sat, 18 Jul 2026 08:58:49 +0000

net: close semantic network coverage

- Derive logging display paths before process-global initialization.
- Exercise both configured and disabled logging path representations.
- Iterate Nostr relay status values directly under all features.
- Remove the public coverage-only probe and verify the strict gate.

Diffstat:
M
crates/net/src/builder.rs
 | 
12
+-----------
M
crates/net/src/logging.rs
 | 
10
+++++-----
M
crates/net/src/nostr_client/status.rs
 | 
2
+-

3 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/crates/net/src/builder.rs b/crates/net/src/builder.rs
@@ -35,13 +35,9 @@ impl NetBuilder {
     }
 }
 
-pub fn coverage_branch_probe(input: bool) -> bool {
-    input
-}
-
 #[cfg(test)]
 mod tests {
-    use super::{NetBuilder, coverage_branch_probe};
+    use super::NetBuilder;
 
     #[test]
     fn manage_runtime_path_is_callable() {
@@ -54,10 +50,4 @@ mod tests {
         let guard = handle.lock();
         assert!(guard.is_ok());
     }
-
-    #[test]
-    fn coverage_branch_probe_hits_both_paths() {
-        assert!(coverage_branch_probe(true));
-        assert!(!coverage_branch_probe(false));
-    }
 }
diff --git a/crates/net/src/logging.rs b/crates/net/src/logging.rs
@@ -20,6 +20,11 @@ impl Default for LoggingOptions {
 }
 
 pub fn init_logging(opts: LoggingOptions) -> Result<()> {
+    let file_path = opts
+        .dir
+        .as_ref()
+        .map(|d| d.join(&opts.file_name).display().to_string())
+        .unwrap_or_else(|| "<disabled>".into());
     let log_opts = radroots_log::LoggingOptions {
         dir: opts.dir.clone(),
         file_name: opts.file_name.clone(),
@@ -32,11 +37,6 @@ pub fn init_logging(opts: LoggingOptions) -> Result<()> {
         Ok(()) => {}
         Err(_) => return Err(NetError::LoggingInit("init")),
     }
-    let file_path = opts
-        .dir
-        .as_ref()
-        .map(|d| d.join(&opts.file_name).display().to_string())
-        .unwrap_or_else(|| "<disabled>".into());
     info!(
         "logging initialized (file: {}, stdout: {})",
         file_path, opts.also_stdout
diff --git a/crates/net/src/nostr_client/status.rs b/crates/net/src/nostr_client/status.rs
@@ -47,7 +47,7 @@ impl NostrClientManager {
         let mut connected = 0usize;
         let mut connecting = 0usize;
 
-        for (_url, st) in map.iter() {
+        for st in map.values() {
             match st {
                 RadrootsNostrRelayStatus::Connected => connected += 1,
                 RadrootsNostrRelayStatus::Connecting => connecting += 1,