commit de35829d6718a3e473029fa48a2de830cadf74a2
parent bf4285ac806c2fc6354d798cb00973f7203ca7b9
Author: triesap <tyson@radroots.org>
Date: Sat, 3 Oct 2026 20:23:26 +0000
fix: refresh Add after editing preservation settles
- Forward settled child protection changes to the Add owner
- Execute the native observer regression before and after repair
- Require actual delivery policy completion within existing bounds
- Preserve measured persona gates and verify standalone source
Diffstat:
4 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/Tera/State/TeraAddAffordances.swift b/Tera/State/TeraAddAffordances.swift
@@ -1,6 +1,11 @@
import Foundation
extension TeraAddStore {
+ func observeChildAffordances() {
+ submissions.changed = { [weak self] in self?.objectWillChange.send() }
+ protection.changed = { [weak self] in self?.objectWillChange.send() }
+ }
+
var canCreateNewComposer: Bool {
!isWorking && submissions.canReplaceEditing && !protection.isWorking && !protection.failed
}
diff --git a/Tera/State/TeraAddStore.swift b/Tera/State/TeraAddStore.swift
@@ -81,7 +81,7 @@ final class TeraAddStore: ObservableObject {
clock: clock
)
mediaAccess.changed = { [weak self] in self?.objectWillChange.send() }
- submissions.changed = { [weak self] in self?.objectWillChange.send() }
+ observeChildAffordances()
composer.stateChanged = { [weak self] in self?.composerState = $0 }
protection.cancelled = { [weak self] in guard let self else { return }; generation = generation.invalidated() }
}
diff --git a/Tera/State/TeraEditingProtection.swift b/Tera/State/TeraEditingProtection.swift
@@ -5,8 +5,23 @@ import Foundation
@MainActor
final class TeraEditingProtection: ObservableObject {
enum Kind { case editing, reopen }
- @Published private(set) var failed = false
- @Published private(set) var isWorking = false
+ @Published private(set) var failed = false {
+ didSet {
+ if failed != oldValue {
+ changed()
+ }
+ }
+ }
+
+ @Published private(set) var isWorking = false {
+ didSet {
+ if isWorking != oldValue {
+ changed()
+ }
+ }
+ }
+
+ var changed: () -> Void = {}
@Published private(set) var reopened: UUID?
var cancelled: () -> Void = {}
private struct Pending {
diff --git a/TeraTests/TeraEditingReplacementTests.swift b/TeraTests/TeraEditingReplacementTests.swift
@@ -1,3 +1,4 @@
+import Combine
import Foundation
@testable import TeraApp
import XCTest
@@ -18,6 +19,11 @@ final class TeraEditingReplacementTests: XCTestCase {
let pause = await backend.pause(.composer)
store.updateForm(\.content, " newer event ")
let editing = TeraComposerForm(editing: store.form)
+ var observedNewAvailability: [Bool] = []
+ let observation = store.objectWillChange.sink {
+ observedNewAvailability.append(store.canCreateNewComposer)
+ }
+ defer { observation.cancel() }
store.selectType(.createAsk)
await pause.entered.wait()
XCTAssertEqual(TeraComposerForm(editing: store.form), editing)
@@ -26,6 +32,8 @@ final class TeraEditingReplacementTests: XCTestCase {
await TeraScopeFixtures.eventually { !store.protection.isWorking }
XCTAssertEqual(store.form.commandType, .createAsk)
XCTAssertEqual(store.form.content, "")
+ XCTAssertEqual(observedNewAvailability.last, true,
+ "Add observers must see New enabled after the preservation worker settles")
let saved = try await client.loadComposer(scope: original.scope, id: original.id)
XCTAssertEqual(saved.form, editing)
XCTAssertEqual(saved.revision, original.revision + 1)