commit 874743da347a434a049d0e3199847fc4839d768e
parent e9294dd397384e95336985bef5b7b3b2779cec9b
Author: triesap <tyson@radroots.org>
Date: Sat, 10 Oct 2026 02:21:44 +0000
fix: Align accessibility audit documentation and fatal assertions (C189)
- Describe retained clipping and unidentified findings without obsolete waivers.
- Share mandatory caller assertions and preserve the disabled Camera contrast policy.
- Test synthetic negative assertions and actual native form and settings audits.
- Register the focused regression source and refresh governed project and release evidence.
Diffstat:
8 files changed, 148 insertions(+), 21 deletions(-)
diff --git a/README.md b/README.md
@@ -172,10 +172,12 @@ cargo extbuild run -- scripts/xcode.sh local-social-ui-test \
accessibility
```
-Element-bound clipping findings remain fatal. The harness tolerates only
-Xcode's elementless clipping diagnostics and narrowly identified contrast
-false positives for disabled controls, system-chrome overlap, and the
-black-on-white Submit button.
+Clipping and unidentified findings remain fatal, as do active contrast
+findings. The sole contrast exception is the actual disabled Camera control.
+Partly obscured elements must be exposed and pass a new native contrast audit;
+system-chrome overlap does not waive a finding. Exhausting the bounded recheck
+attempts fails the test. Both audit callers assert that no findings remain,
+including findings returned while a native scan continues.
Passing `persona` runs the strict five-persona, 15-attempt deterministic
local-social matrix serially. Each persona receives a fresh run-scoped native
diff --git a/Tera.xcodeproj/project.pbxproj b/Tera.xcodeproj/project.pbxproj
@@ -159,6 +159,7 @@
F8DB757CAC7AB2136483EC2B /* TeraComposerSaveSchedulingTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3C51E210CC4A6734CD302452 /* TeraComposerSaveSchedulingTests.swift */; };
FB585785DC906CB2AE4AE535 /* TeraBindingPortabilityTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 58E711687008866790042792 /* TeraBindingPortabilityTests.swift */; };
FBA9C3463CD1827392AF9599 /* TeraAddSchemaFixtures.swift in Sources */ = {isa = PBXBuildFile; fileRef = D8ED2718D5E9E8980ADF3423 /* TeraAddSchemaFixtures.swift */; };
+ FE21D4FDC0E89F0D2EEF3515 /* TeraAccessibilityAuditPolicyUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 69D9D6F4A3E2131C6EF5D40D /* TeraAccessibilityAuditPolicyUITests.swift */; };
/* End PBXBuildFile section */
/* Begin PBXContainerItemProxy section */
@@ -237,6 +238,7 @@
649F88AE533C3BEEBC466894 /* TeraOfflineMediaTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraOfflineMediaTests.swift; sourceTree = "<group>"; };
67ACCE25979BA86C1EC5BFD6 /* App.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = App.swift; sourceTree = "<group>"; };
6967B3EAC4CF1A410B26DD1A /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
+ 69D9D6F4A3E2131C6EF5D40D /* TeraAccessibilityAuditPolicyUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraAccessibilityAuditPolicyUITests.swift; sourceTree = "<group>"; };
6A506C45B5EE1AAEF0D7F671 /* TeraNativeRepairTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraNativeRepairTests.swift; sourceTree = "<group>"; };
6B8677670E203FF68EC88983 /* TeraRootShellTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraRootShellTests.swift; sourceTree = "<group>"; };
6C3FA83C2A58487CA3AA2C9E /* TeraAddViewportUI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraAddViewportUI.swift; sourceTree = "<group>"; };
@@ -370,6 +372,7 @@
isa = PBXGroup;
children = (
CC5289B0C8C497EB52BF6DE1 /* TeraAccessibilityAudit.swift */,
+ 69D9D6F4A3E2131C6EF5D40D /* TeraAccessibilityAuditPolicyUITests.swift */,
D159B8D5E2417578E1C88FC1 /* TeraAccessibilityUITests.swift */,
6C3FA83C2A58487CA3AA2C9E /* TeraAddViewportUI.swift */,
0D243145C276EBF17915AB4E /* TeraEditingProtectionUITests.swift */,
@@ -893,6 +896,7 @@
buildActionMask = 2147483647;
files = (
39EC97809DDF74F40641AAE8 /* TeraAccessibilityAudit.swift in Sources */,
+ FE21D4FDC0E89F0D2EEF3515 /* TeraAccessibilityAuditPolicyUITests.swift in Sources */,
542968135071D02F02BD4614 /* TeraAccessibilityUITests.swift in Sources */,
124F9E43396AE2148BD0D481 /* TeraAddViewportUI.swift in Sources */,
6F09A1AF6E764AC0136E8F74 /* TeraEditingProtectionUITests.swift in Sources */,
diff --git a/TeraUITests/TeraAccessibilityAudit.swift b/TeraUITests/TeraAccessibilityAudit.swift
@@ -9,6 +9,32 @@ final class TeraAccessibilityAudit {
self.test = test
}
+ static func assertNoFindings(_ findings: [String], file: StaticString = #filePath, line: UInt = #line) {
+ XCTAssertTrue(findings.isEmpty, "Unresolved accessibility findings:\n" + findings.joined(separator: "\n"),
+ file: file, line: line)
+ }
+
+ static func retainFinding(_ description: String, elementLabel: String?, in findings: inout [String]) -> Bool {
+ findings.append("\(description): \(elementLabel ?? "unidentified")")
+ // Continuing a native scan does not waive the mandatory caller assertion.
+ return true
+ }
+
+ static func contrastDisposition(label: String?, isEnabled: Bool, cameraIsDisabled: Bool,
+ isRequestedTarget: Bool,
+ isPartlyOccluded: Bool) -> TeraAccessibilityContrastDisposition
+ {
+ guard let label else { return .retain }
+ if label == "Camera", !isEnabled, cameraIsDisabled {
+ return .disabledCamera
+ }
+ return !isRequestedTarget && isPartlyOccluded ? .recheck : .retain
+ }
+
+ static func failContrastRechecks(file: StaticString = #filePath, line: UInt = #line) {
+ XCTFail("Not all partially obscured contrast findings passed an unobscured recheck", file: file, line: line)
+ }
+
func run(_ app: XCUIApplication, dynamicType: Bool = false, includeContrast: Bool = true) throws -> [String] {
// Native scans can move focus and scroll position. Audit clipping before
// those scans and retain every finding, including unidentified ones.
@@ -225,12 +251,17 @@ private extension TeraAccessibilityAudit {
guard let element = issue.element else { return self.retainFinding(issue) }
// SC 1.4.3 exempts inactive controls. Keep this bound to the actual
// disabled camera control; no active text or clipping finding is exempt.
- if element.label == "Camera", !element.isEnabled,
- app.buttons["Camera"].exists, !app.buttons["Camera"].isEnabled {
- return true
- }
let key = self.contrastKey(element)
- guard key != targetKey, self.isPartlyOccluded(element, app: app) else { return self.retainFinding(issue) }
+ let camera = app.buttons["Camera"]
+ let disposition = Self.contrastDisposition(label: element.label, isEnabled: element.isEnabled,
+ cameraIsDisabled: camera.exists && !camera.isEnabled,
+ isRequestedTarget: key == targetKey,
+ isPartlyOccluded: self.isPartlyOccluded(element, app: app))
+ switch disposition {
+ case .disabledCamera: return true
+ case .retain: return self.retainFinding(issue)
+ case .recheck: break
+ }
if !verified.contains(key) {
pending[key] = TeraAuditTarget(element, app: app)
}
@@ -251,14 +282,11 @@ private extension TeraAccessibilityAudit {
guard let next = pending.keys.sorted().first else { return }
requested = pending.removeValue(forKey: next)
}
- XCTFail("Not all partially obscured contrast findings passed an unobscured recheck")
+ Self.failContrastRechecks()
}
func retainFinding(_ issue: XCUIAccessibilityAuditIssue) -> Bool {
- findings.append("\(issue.compactDescription): \(issue.element?.label ?? "unidentified")")
- // Return every finding to the calling test for a mandatory assertion.
- // Continuing this scan does not waive the finding.
- return true
+ Self.retainFinding(issue.compactDescription, elementLabel: issue.element?.label, in: &findings)
}
func contrastKey(_ element: XCUIElement) -> String {
@@ -275,6 +303,10 @@ private extension TeraAccessibilityAudit {
}
}
+enum TeraAccessibilityContrastDisposition: Equatable {
+ case retain, recheck, disabledCamera
+}
+
private struct TeraAuditTarget {
let type: XCUIElement.ElementType
let identifier: String
diff --git a/TeraUITests/TeraAccessibilityAuditPolicyUITests.swift b/TeraUITests/TeraAccessibilityAuditPolicyUITests.swift
@@ -0,0 +1,88 @@
+import XCTest
+
+final class TeraAccessibilityAuditPolicyUITests: XCTestCase {
+ private var capturingAssertion = false
+ private var capturedAssertions: [XCTIssue] = []
+
+ override func record(_ issue: XCTIssue) {
+ if capturingAssertion, issue.type == .assertionFailure {
+ capturedAssertions.append(issue)
+ } else {
+ super.record(issue)
+ }
+ }
+
+ @MainActor
+ func testEmptyAuditDoesNotAssert() {
+ XCTAssertTrue(captureAssertion { TeraAccessibilityAudit.assertNoFindings([]) }.isEmpty)
+ }
+
+ @MainActor
+ func testUnidentifiedAndClippingFindingsRemainFatal() {
+ for label in [nil, "Submit"] as [String?] {
+ var findings: [String] = []
+ XCTAssertTrue(TeraAccessibilityAudit.retainFinding("Text clipped", elementLabel: label, in: &findings))
+ XCTAssertEqual(findings.count, 1)
+ let failures = captureAssertion { TeraAccessibilityAudit.assertNoFindings(findings) }
+ XCTAssertEqual(failures.count, 1)
+ XCTAssertTrue(failures.first?.compactDescription.contains(label ?? "unidentified") == true)
+ }
+ }
+
+ @MainActor
+ func testActiveContrastFindingsRemainFatal() {
+ XCTAssertEqual(disposition(label: "Submit", enabled: true), .retain)
+ var findings: [String] = []
+ XCTAssertTrue(TeraAccessibilityAudit.retainFinding("Contrast", elementLabel: "Submit", in: &findings))
+ XCTAssertEqual(captureAssertion { TeraAccessibilityAudit.assertNoFindings(findings) }.count, 1)
+ }
+
+ @MainActor
+ func testDisabledCameraExceptionCannotMatchEnabledOrOtherControls() {
+ XCTAssertEqual(disposition(label: "Camera", enabled: false), .disabledCamera)
+ XCTAssertEqual(disposition(label: "Camera", enabled: true), .retain)
+ XCTAssertEqual(disposition(label: "Camera", enabled: false, cameraEnabled: true), .retain)
+ XCTAssertEqual(disposition(label: "Camera", enabled: false, cameraExists: false), .retain)
+ XCTAssertEqual(disposition(label: "Submit", enabled: false), .retain)
+ XCTAssertEqual(disposition(label: "Submit", enabled: true), .retain)
+ XCTAssertEqual(disposition(label: nil, enabled: false), .retain)
+ }
+
+ @MainActor
+ func testPartlyOccludedContrastRequiresNewUnobscuredAudit() {
+ XCTAssertEqual(disposition(label: "Section", enabled: true, occluded: true), .recheck)
+ // The requested target's new audit must retain a continuing finding.
+ XCTAssertEqual(disposition(label: "Section", enabled: true, requested: true, occluded: true), .retain)
+ XCTAssertEqual(disposition(label: "Section", enabled: true, requested: true), .retain)
+ XCTAssertEqual(disposition(label: nil, enabled: false, occluded: true), .retain)
+ }
+
+ @MainActor
+ func testRecheckExhaustionIsFatal() {
+ let failures = captureAssertion { TeraAccessibilityAudit.failContrastRechecks() }
+ XCTAssertEqual(failures.count, 1)
+ XCTAssertTrue(failures.first?.compactDescription.contains("unobscured recheck") == true)
+ }
+
+ @MainActor
+ private func captureAssertion(_ action: () -> Void) -> [XCTIssue] {
+ // Only this separate synthetic control class captures its injected,
+ // synchronous assertion. Native product audits never use this override.
+ XCTAssertFalse(capturingAssertion)
+ capturedAssertions.removeAll()
+ capturingAssertion = true
+ defer { capturingAssertion = false }
+ action()
+ return capturedAssertions
+ }
+
+ @MainActor
+ private func disposition(label: String?, enabled: Bool, cameraExists: Bool = true,
+ cameraEnabled: Bool = false, requested: Bool = false,
+ occluded: Bool = false) -> TeraAccessibilityContrastDisposition
+ {
+ TeraAccessibilityAudit.contrastDisposition(label: label, isEnabled: enabled,
+ cameraIsDisabled: cameraExists && !cameraEnabled,
+ isRequestedTarget: requested, isPartlyOccluded: occluded)
+ }
+}
diff --git a/TeraUITests/TeraAccessibilityUITests.swift b/TeraUITests/TeraAccessibilityUITests.swift
@@ -6,7 +6,7 @@ final class TeraAccessibilityUITests: XCTestCase {
override func tearDown() async throws {
continueAfterFailure = true
- XCTAssertTrue(auditFindings.isEmpty, "Unresolved accessibility findings:\n" + auditFindings.joined(separator: "\n"))
+ TeraAccessibilityAudit.assertNoFindings(auditFindings)
auditFindings.removeAll()
try await super.tearDown()
}
diff --git a/TeraUITests/TeraRemoteQualificationUITests.swift b/TeraUITests/TeraRemoteQualificationUITests.swift
@@ -450,7 +450,7 @@ final class TeraRemoteQualificationUITests: XCTestCase {
includeContrast: Bool = true
) throws {
let findings = try TeraAccessibilityAudit(test: self).run(app, includeContrast: includeContrast)
- XCTAssertTrue(findings.isEmpty, "Unresolved accessibility findings:\n" + findings.joined(separator: "\n"))
+ TeraAccessibilityAudit.assertNoFindings(findings)
}
@MainActor
diff --git a/project.yml b/project.yml
@@ -197,6 +197,7 @@ targets:
- path: TeraUITests/TeraRootShellUITests.swift
- path: TeraUITests/TeraAccessibilityUITests.swift
- path: TeraUITests/TeraAccessibilityAudit.swift
+ - path: TeraUITests/TeraAccessibilityAuditPolicyUITests.swift
- path: TeraUITests/TeraEditingProtectionUITests.swift
- path: TeraUITests/TeraRecoveryUITests.swift
- path: TeraUITests/TeraPhotoQualificationInput.swift
diff --git a/release/provenance.json b/release/provenance.json
@@ -6,7 +6,7 @@
"info_plist_sha256": "b55010dd73b34bf5ad910a888be0ea1ae45f2a5c14329fa6a57059a317bdbd42",
"privacy_manifest_sha256": "0f2103257ba596fbcaeb1d6a4dffe3ae021e84c010178852c6bf500a8cfb0f19",
"sbom_sha256": "3b7fc006547d0551e0ac65d6e4dba414803ee1ebceab58d1f385dda98b2df7ef",
- "xcode_project_sha256": "82058b7de145811d85aadab19e430cf02fd319aa01681cf418b3c1ff1343a768"
+ "xcode_project_sha256": "c5e7027969b51dc93f3eacd509f795d666d9bd382f6bee506b7d6c88c704eaeb"
},
"disposition": "unsigned",
"platforms": [
@@ -1250,14 +1250,14 @@
"sha256": "0e28b784839be43bf9dd818f1f1bd494cbafd6d9fd021764e09a12b493545d16"
},
"project.yml": {
- "bytes": 10197,
- "git_blob": "e324dc74283ec1dd8c94c0c6ba93b42158b348ac",
+ "bytes": 10265,
+ "git_blob": "e91aa894d7c867ac9ee9f705a0287d993f194ac9",
"mode": "100644",
- "sha256": "ee0feb2a0710ed94d620e54e580d011c96628292435049b7931365c219f9533f"
+ "sha256": "804dbdb183582a7563b72498e5c5e22f1b78cc5841edae82037f04544f9c8a5a"
}
},
"policy": "staged_inputs",
- "tree": "9e3bde8e5b90f38792f8524bd89f05ce7e413d7d"
+ "tree": "fb3fbebbca86007a6221955fb6b29941872aadae"
},
"cargo_lock_sha256": "67bcbc7cf880e3ffb6e01c193d4e63dc007ed74335f066077dbac87a40514817",
"consumer_source_lock_sha256": "eadc233fb6b20d32960ae1b2b444a58c1ee146045c29c037a168b603dcd99555",