commit 7442bb50026bc179f6405fd1cbebb7a0591d3036
parent 927f8820537819c7eb1f4bfef6df9926e09e9612
Author: triesap <tyson@radroots.org>
Date: Sat, 3 Oct 2026 01:45:03 +0000
test: reject Add controls obscured by navigation
- Bound controls below navigation and above the tab bar
- Preserve focus assertions and the native swipe budget
- Decrease existing lint debt without producer changes
- Verify actual loopbacks and the complete standalone lane
Diffstat:
7 files changed, 31 insertions(+), 21 deletions(-)
diff --git a/Tera.xcodeproj/project.pbxproj b/Tera.xcodeproj/project.pbxproj
@@ -16,6 +16,7 @@
1077ED6CD94589B273E94F06 /* TeraVisibilityTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6308AE4246EA401D29F36496 /* TeraVisibilityTests.swift */; };
116EF45DA06343BA3FA697AD /* TeraFoodDecimalEntryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 547AD45DC8C58FC4AA0D073D /* TeraFoodDecimalEntryTests.swift */; };
11F4583DF23972489EDCBDE7 /* TeraHistoricalOwnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 32207238333C60B9B9E9791C /* TeraHistoricalOwnerTests.swift */; };
+ 124F9E43396AE2148BD0D481 /* TeraAddViewportUI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6C3FA83C2A58487CA3AA2C9E /* TeraAddViewportUI.swift */; };
1381A92874CF80925EEC06F5 /* TeraComposerMediaOwnershipTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = BE713B98919CB7692E3104A9 /* TeraComposerMediaOwnershipTests.swift */; };
141327BC6BAE2CFA2C62C584 /* TeraTodayReconciliationTaskTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5EB21C33D6173E4FED05FDA0 /* TeraTodayReconciliationTaskTests.swift */; };
17805D95512D7144DAC59D85 /* TeraTodayRenderingTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7283D1C8F6E90A236BC84AF6 /* TeraTodayRenderingTests.swift */; };
@@ -234,6 +235,7 @@
6967B3EAC4CF1A410B26DD1A /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
6A506C45B5EE1AAEF0D7F671 /* TeraNativeRepairTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraNativeRepairTests.swift; sourceTree = "<group>"; };
6B8677670E203FF68EC88983 /* TeraRootShellTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraRootShellTests.swift; sourceTree = "<group>"; };
+ 6C3FA83C2A58487CA3AA2C9E /* TeraAddViewportUI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraAddViewportUI.swift; sourceTree = "<group>"; };
6D2BE93A0818202625CAF1F5 /* TeraTodayCalendarScopeTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraTodayCalendarScopeTests.swift; sourceTree = "<group>"; };
6D536D6625083ACB3DA4A674 /* TeraComposerDurabilityBoundaryTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraComposerDurabilityBoundaryTests.swift; sourceTree = "<group>"; };
6F617B18A76B833F3575487F /* TeraExactDecimalPresentationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraExactDecimalPresentationTests.swift; sourceTree = "<group>"; };
@@ -363,6 +365,7 @@
children = (
CC5289B0C8C497EB52BF6DE1 /* TeraAccessibilityAudit.swift */,
D159B8D5E2417578E1C88FC1 /* TeraAccessibilityUITests.swift */,
+ 6C3FA83C2A58487CA3AA2C9E /* TeraAddViewportUI.swift */,
0D243145C276EBF17915AB4E /* TeraEditingProtectionUITests.swift */,
FD65DE234C7DD80CE3CB91EB /* TeraPhotoQualificationInput.swift */,
A5928D5CAC9F8EF904547DF8 /* TeraRecoveryUITests.swift */,
@@ -881,6 +884,7 @@
files = (
39EC97809DDF74F40641AAE8 /* TeraAccessibilityAudit.swift in Sources */,
542968135071D02F02BD4614 /* TeraAccessibilityUITests.swift in Sources */,
+ 124F9E43396AE2148BD0D481 /* TeraAddViewportUI.swift in Sources */,
6F09A1AF6E764AC0136E8F74 /* TeraEditingProtectionUITests.swift in Sources */,
25CCFD77EFA43657C473ADDC /* TeraPhotoQualificationInput.swift in Sources */,
F8A87EA68BEF06EA7F0838D0 /* TeraRecoveryUITests.swift in Sources */,
diff --git a/TeraUITests/TeraAddViewportUI.swift b/TeraUITests/TeraAddViewportUI.swift
@@ -0,0 +1,20 @@
+import XCTest
+
+extension TeraRemoteQualificationUITests {
+ @MainActor
+ func isVisibleInAddViewport(
+ _ element: XCUIElement,
+ root: XCUIElement,
+ above obstruction: XCUIElement,
+ below navigation: XCUIElement
+ ) -> Bool {
+ guard element.exists, element.isHittable, root.exists, obstruction.exists, navigation.exists else {
+ return false
+ }
+ let frame = element.frame
+ let rootFrame = root.frame
+ return frame.height > 0
+ && frame.minY >= max(rootFrame.minY, navigation.frame.maxY)
+ && frame.maxY <= min(rootFrame.maxY, obstruction.frame.minY)
+ }
+}
diff --git a/TeraUITests/TeraRemoteQualificationUITests.swift b/TeraUITests/TeraRemoteQualificationUITests.swift
@@ -990,7 +990,8 @@ final class TeraRemoteQualificationUITests: XCTestCase {
for attempt in 0 ..< 16 where !isVisibleInAddViewport(
element,
root: root,
- above: tabBar
+ above: tabBar,
+ below: app.navigationBars["Add"]
) {
if element.exists {
let targetFrame = element.frame
@@ -1009,22 +1010,6 @@ final class TeraRemoteQualificationUITests: XCTestCase {
}
@MainActor
- private func isVisibleInAddViewport(
- _ element: XCUIElement,
- root: XCUIElement,
- above obstruction: XCUIElement
- ) -> Bool {
- guard element.exists, element.isHittable, root.exists, obstruction.exists else {
- return false
- }
- let frame = element.frame
- let rootFrame = root.frame
- return frame.height > 0
- && frame.minY >= rootFrame.minY
- && frame.maxY <= min(rootFrame.maxY, obstruction.frame.minY)
- }
-
- @MainActor
private func scrollAddFormToTop(_ app: XCUIApplication) {
let root = app.descendants(matching: .any)["radroots.add.root"]
for _ in 0 ..< 8 {
diff --git a/project.yml b/project.yml
@@ -201,6 +201,7 @@ targets:
- path: TeraUITests/TeraPhotoQualificationInput.swift
- path: TeraUITests/TeraRemoteQualificationUITests.swift
- path: TeraUITests/TeraSettingsIdentityUI.swift
+ - path: TeraUITests/TeraAddViewportUI.swift
- path: TeraUITests/TeraSubmissionQualificationSupport.swift
- path: test-fixtures/local-social-personas.v1.json
buildPhase: resources
diff --git a/release/provenance.json b/release/provenance.json
@@ -6,7 +6,7 @@
"info_plist_sha256": "b55010dd73b34bf5ad910a888be0ea1ae45f2a5c14329fa6a57059a317bdbd42",
"privacy_manifest_sha256": "0f2103257ba596fbcaeb1d6a4dffe3ae021e84c010178852c6bf500a8cfb0f19",
"sbom_sha256": "f0a15c2c9ad7799539fbc52fd1fdbcf17f4046b6f86cfe0a9b8980adc0079e10",
- "xcode_project_sha256": "49c796d1ac0693a7bb276ec927e5dcf8566719eb59feea7792fa4d31adde84a8"
+ "xcode_project_sha256": "8c10bd4b87d8d02a06e7d212b7da75738bc46c29316156424feb2a7c61521af1"
},
"disposition": "unsigned",
"platforms": [
diff --git a/test-fixtures/maintainability-baseline.v1.json b/test-fixtures/maintainability-baseline.v1.json
@@ -38,7 +38,7 @@
},
{
"path": "TeraUITests/TeraRemoteQualificationUITests.swift",
- "maximum_lines": 1971
+ "maximum_lines": 1956
}
],
"python_file_exception": [
diff --git a/test-fixtures/swiftlint-maintainability-baseline.v1.json b/test-fixtures/swiftlint-maintainability-baseline.v1.json
@@ -1 +1 @@
-[{"text":" init(","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"Tera\/App\/TeraAppModel.swift","line":21,"character":3},"reason":"Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines"}},{"text":"final class TeraGeneratedRuntimeBackend: TeraRuntimeBackend, @unchecked Sendable {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift","line":31,"character":7},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 373 lines"}},{"text":"}","violation":{"severity":"error","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift","line":1089,"character":1},"reason":"File should contain 1000 lines or less: currently contains 1089"}},{"text":"actor TeraRuntimeClient {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"Tera\/Runtime\/TeraRuntimeClient.swift","line":3,"character":1},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 675 lines"}},{"text":" func changes(bufferCapacity: Int = 16) async throws -> AsyncStream<TeraRuntimeChange> {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"Tera\/Runtime\/TeraRuntimeClient.swift","line":353,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 70 lines"}},{"text":"}","violation":{"severity":"warning","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"Tera\/Runtime\/TeraRuntimeClient.swift","line":749,"character":1},"reason":"File should contain 400 lines or less: currently contains 749"}},{"text":"}","violation":{"severity":"error","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"Tera\/Runtime\/TeraRuntimeModels.swift","line":1029,"character":1},"reason":"File should contain 1000 lines or less: currently contains 1029"}},{"text":"final class TeraAddStore: ObservableObject {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"Tera\/State\/TeraAddStore.swift","line":4,"character":7},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 481 lines"}},{"text":"}","violation":{"severity":"warning","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"Tera\/State\/TeraAddStore.swift","line":702,"character":1},"reason":"File should contain 400 lines or less: currently contains 702"}},{"text":"actor TeraConfigurationStore {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"Tera\/State\/TeraConfigurationStore.swift","line":78,"character":1},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 468 lines"}},{"text":" func load() throws -> TeraAppConfiguration {","violation":{"severity":"error","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"Tera\/State\/TeraConfigurationStore.swift","line":148,"character":5},"reason":"Function body should span 100 lines or less excluding comments and whitespace: currently spans 109 lines"}},{"text":"}","violation":{"severity":"warning","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"Tera\/State\/TeraConfigurationStore.swift","line":759,"character":1},"reason":"File should contain 400 lines or less: currently contains 759"}},{"text":" private func start(acceptingReconfiguration: Bool) async -> TeraSessionPhase {","violation":{"severity":"warning","ruleDescription":"Complexity of function bodies should be limited.","ruleIdentifier":"cyclomatic_complexity","ruleName":"Cyclomatic Complexity","location":{"file":"Tera\/State\/TeraSessionStore.swift","line":96,"character":11},"reason":"Function should have complexity 10 or less; currently complexity is 13"}},{"text":"final class TeraAddStoreTests: XCTestCase {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraTests\/TeraAddStoreTests.swift","line":6,"character":7},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 607 lines"}},{"text":"actor AddBackend: TeraRuntimeBackend {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraTests\/TeraAddStoreTests.swift","line":682,"character":1},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 394 lines"}},{"text":" func makeStatus(","violation":{"severity":"warning","ruleDescription":"Number of function parameters should be low.","ruleIdentifier":"function_parameter_count","ruleName":"Function Parameter Count","location":{"file":"TeraTests\/TeraAddStoreTests.swift","line":1020,"character":3},"reason":"Function should have 5 parameters or less: it currently has 8"}},{"text":"}","violation":{"severity":"error","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"TeraTests\/TeraAddStoreTests.swift","line":1232,"character":1},"reason":"File should contain 1000 lines or less: currently contains 1232"}},{"text":"final class TeraRemoteQualificationTests: XCTestCase {","violation":{"severity":"warning","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraTests\/TeraRemoteQualificationTests.swift","line":7,"character":7},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines"}},{"text":" func testQualificationRejectsAmbiguousOrUnsafeHarnessValues() {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraTests\/TeraRemoteQualificationTests.swift","line":45,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 94 lines"}},{"text":" func testAuthorizationEvidenceIsRedactedEphemeralAndRelaunchCleaned() throws {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraTests\/TeraRemoteQualificationTests.swift","line":212,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines"}},{"text":"final class TeraRuntimeClientTests: XCTestCase {","violation":{"severity":"warning","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraTests\/TeraRuntimeClientTests.swift","line":4,"character":7},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 298 lines"}},{"text":"final class TeraStateMigrationTests: XCTestCase {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraTests\/TeraStateMigrationTests.swift","line":6,"character":7},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 580 lines"}},{"text":" func testRelayValidationMatchesRuntimeProfiles() throws {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraTests\/TeraStateMigrationTests.swift","line":7,"character":5},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 61 lines"}},{"text":"}","violation":{"severity":"warning","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"TeraTests\/TeraStateMigrationTests.swift","line":622,"character":1},"reason":"File should contain 400 lines or less: currently contains 622"}},{"text":"final class TeraRemoteQualificationUITests: XCTestCase {","violation":{"severity":"error","ruleDescription":"Type bodies should not span too many lines","ruleIdentifier":"type_body_length","ruleName":"Type Body Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":4,"character":7},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 1265 lines"}},{"text":" func testLocalSocialFiveFlowScenario() throws {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":62,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 65 lines"}},{"text":" func testLocalSocialDeterministicPersonas() throws {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":166,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 66 lines"}},{"text":" func testRemoteBlossomUploadAndRecovery() throws {","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":239,"character":3},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines"}},{"text":" private func expectedAddFieldLabel(_ identifier: String, type: String) -> String {","violation":{"severity":"warning","ruleDescription":"Complexity of function bodies should be limited.","ruleIdentifier":"cyclomatic_complexity","ruleName":"Cyclomatic Complexity","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":494,"character":11},"reason":"Function should have complexity 10 or less; currently complexity is 18"}},{"text":" static func environment(","violation":{"severity":"warning","ruleDescription":"Function bodies should not span too many lines","ruleIdentifier":"function_body_length","ruleName":"Function Body Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":1495,"character":10},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 67 lines"}},{"text":"}","violation":{"severity":"error","ruleDescription":"Files should not span too many lines.","ruleIdentifier":"file_length","ruleName":"File Length","location":{"file":"TeraUITests\/TeraRemoteQualificationUITests.swift","line":1971,"character":1},"reason":"File should contain 1000 lines or less: currently contains 1971"}}]
-\ No newline at end of file
+[{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":21,"file":"Tera\/App\/TeraAppModel.swift"},"reason":"Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" init("},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":31,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 373 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraGeneratedRuntimeBackend: TeraRuntimeBackend, @unchecked Sendable {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1089,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"},"reason":"File should contain 1000 lines or less: currently contains 1089","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":3,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 675 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor TeraRuntimeClient {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":353,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 70 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func changes(bufferCapacity: Int = 16) async throws -> AsyncStream<TeraRuntimeChange> {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":749,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"File should contain 400 lines or less: currently contains 749","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1029,"file":"Tera\/Runtime\/TeraRuntimeModels.swift"},"reason":"File should contain 1000 lines or less: currently contains 1029","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":4,"file":"Tera\/State\/TeraAddStore.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 481 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraAddStore: ObservableObject {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":702,"file":"Tera\/State\/TeraAddStore.swift"},"reason":"File should contain 400 lines or less: currently contains 702","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":78,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 468 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor TeraConfigurationStore {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"error","location":{"character":5,"line":148,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"Function body should span 100 lines or less excluding comments and whitespace: currently spans 109 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func load() throws -> TeraAppConfiguration {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":759,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"File should contain 400 lines or less: currently contains 759","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Complexity of function bodies should be limited.","severity":"warning","location":{"character":11,"line":96,"file":"Tera\/State\/TeraSessionStore.swift"},"reason":"Function should have complexity 10 or less; currently complexity is 13","ruleName":"Cyclomatic Complexity","ruleIdentifier":"cyclomatic_complexity"},"text":" private func start(acceptingReconfiguration: Bool) async -> TeraSessionPhase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":6,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 607 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraAddStoreTests: XCTestCase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":682,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 394 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor AddBackend: TeraRuntimeBackend {"},{"violation":{"ruleDescription":"Number of function parameters should be low.","severity":"warning","location":{"character":3,"line":1020,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Function should have 5 parameters or less: it currently has 8","ruleName":"Function Parameter Count","ruleIdentifier":"function_parameter_count"},"text":" func makeStatus("},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1232,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"File should contain 1000 lines or less: currently contains 1232","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"warning","location":{"character":7,"line":7,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRemoteQualificationTests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":45,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 94 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testQualificationRejectsAmbiguousOrUnsafeHarnessValues() {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":212,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testAuthorizationEvidenceIsRedactedEphemeralAndRelaunchCleaned() throws {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"warning","location":{"character":7,"line":4,"file":"TeraTests\/TeraRuntimeClientTests.swift"},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 298 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRuntimeClientTests: XCTestCase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":6,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 580 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraStateMigrationTests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":5,"line":7,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 61 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testRelayValidationMatchesRuntimeProfiles() throws {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":622,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"File should contain 400 lines or less: currently contains 622","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":4,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 1251 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRemoteQualificationUITests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":62,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 65 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testLocalSocialFiveFlowScenario() throws {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":166,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 66 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testLocalSocialDeterministicPersonas() throws {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":239,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testRemoteBlossomUploadAndRecovery() throws {"},{"violation":{"ruleDescription":"Complexity of function bodies should be limited.","severity":"warning","location":{"character":11,"line":494,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function should have complexity 10 or less; currently complexity is 18","ruleName":"Cyclomatic Complexity","ruleIdentifier":"cyclomatic_complexity"},"text":" private func expectedAddFieldLabel(_ identifier: String, type: String) -> String {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":10,"line":1480,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 67 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" static func environment("},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1956,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"File should contain 1000 lines or less: currently contains 1956","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"}]
+\ No newline at end of file