field_ios

In-the-field app for Radroots on iOS
git clone https://radroots.dev/git/field_ios.git
Log | Files | Refs | README | LICENSE

commit 18f4cf80a19d2cd934700822e4f798cb011fe028
parent 3aead36faf2ce5f45bd4280e1bdaa9a693ad8abc
Author: triesap <tyson@radroots.org>
Date:   Sat,  3 Oct 2026 06:13:39 +0000

test: preserve reserved identity during validation recovery

- Retain the original missing-title rejection and editing evidence
- Use explicit New for the corrected Event request
- Decrease existing lint debt without producer changes
- Verify loopbacks and the complete standalone lane

Diffstat:
MTera.xcodeproj/project.pbxproj | 4++++
MTeraUITests/TeraRemoteQualificationUITests.swift | 8+++-----
ATeraUITests/TeraValidationRecoveryUI.swift | 17+++++++++++++++++
Mproject.yml | 1+
Mrelease/provenance.json | 2+-
Mtest-fixtures/maintainability-baseline.v1.json | 2+-
Mtest-fixtures/swiftlint-maintainability-baseline.v1.json | 4++--
7 files changed, 29 insertions(+), 9 deletions(-)

diff --git a/Tera.xcodeproj/project.pbxproj b/Tera.xcodeproj/project.pbxproj @@ -132,6 +132,7 @@ CFB2A482663DDB44C263D4CF /* TeraRevisionTestBackend.swift in Sources */ = {isa = PBXBuildFile; fileRef = A48EE7852ECF14C15F7DD902 /* TeraRevisionTestBackend.swift */; }; CFE386A2E4F9D50F0DF57036 /* TeraNativeRepairTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A506C45B5EE1AAEF0D7F671 /* TeraNativeRepairTests.swift */; }; D1C6D5CF5F60ED2646465AF6 /* TeraNativeExecutionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = C9849DFB0F2822630588D59F /* TeraNativeExecutionTests.swift */; }; + D263FCB5A968627B48279458 /* TeraValidationRecoveryUI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9D4EAB5F1EF436E34D348FEB /* TeraValidationRecoveryUI.swift */; }; D4AB00DF764260BC4E1B1454 /* TeraUploadRenewalFFITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4738A984B18FCFCD96D8DFF7 /* TeraUploadRenewalFFITests.swift */; }; D64AC2FDC6FE05A39114D2DB /* TeraMediaFileFixture.swift in Sources */ = {isa = PBXBuildFile; fileRef = D3C914B349DAE2EF66658229 /* TeraMediaFileFixture.swift */; }; D86A417A36A2186AB7777753 /* TeraTodayReconciliationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 714B4DD70B881D29A89812C9 /* TeraTodayReconciliationTests.swift */; }; @@ -270,6 +271,7 @@ 99BE248D1450D76476255626 /* TeraTodayPresentationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraTodayPresentationTests.swift; sourceTree = "<group>"; }; 9B10B1F3C7FCD9A72F04FC00 /* TeraOpenedMediaTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraOpenedMediaTests.swift; sourceTree = "<group>"; }; 9BC55E41FBE589010038FDA5 /* TeraTodaySyncReceiptTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraTodaySyncReceiptTests.swift; sourceTree = "<group>"; }; + 9D4EAB5F1EF436E34D348FEB /* TeraValidationRecoveryUI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraValidationRecoveryUI.swift; sourceTree = "<group>"; }; 9ED6D3E35C3235B6068E1902 /* TeraScopeBackend.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraScopeBackend.swift; sourceTree = "<group>"; }; 9F22CFABCF27A28408F68D25 /* TeraAddStoreTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TeraAddStoreTests.swift; sourceTree = "<group>"; }; 9F54FC4930051FC4611B37D3 /* tera */ = {isa = PBXFileReference; lastKnownFileType = folder; name = tera; path = .; sourceTree = SOURCE_ROOT; }; @@ -373,6 +375,7 @@ 5238B5F236C392C82CEF9838 /* TeraRootShellUITests.swift */, 719F870DBDC5105D134E678E /* TeraSettingsIdentityUI.swift */, 019FAA997BEDE9CC84785DAE /* TeraSubmissionQualificationSupport.swift */, + 9D4EAB5F1EF436E34D348FEB /* TeraValidationRecoveryUI.swift */, ); path = TeraUITests; sourceTree = "<group>"; @@ -892,6 +895,7 @@ DF97F408D7D32F72C5AF5939 /* TeraRootShellUITests.swift in Sources */, 3E373FF6F0BDE19F302097A6 /* TeraSettingsIdentityUI.swift in Sources */, 41ED082A17594FE682A381DD /* TeraSubmissionQualificationSupport.swift in Sources */, + D263FCB5A968627B48279458 /* TeraValidationRecoveryUI.swift in Sources */, ); runOnlyForDeploymentPostprocessing = 0; }; diff --git a/TeraUITests/TeraRemoteQualificationUITests.swift b/TeraUITests/TeraRemoteQualificationUITests.swift @@ -802,10 +802,8 @@ final class TeraRemoteQualificationUITests: XCTestCase { guard let submit = readySubmit(app), let value = submitAndWait(app, submit: submit) else { throw QualificationError.missingProductSurface } - XCTAssertTrue(value.contains("Error code")) let content = app.descendants(matching: .any)["radroots.add.content"] - scrollTo(app, element: content) - XCTAssertEqual(content.value as? String, attempt.marker) + try recoverRejectedEvent(app, content: content, marker: attempt.marker, failure: value) try enterText(app, identifier: "radroots.add.title", value: attempt.marker) try submitSuccessfully(app) return PersonaInteractionObservation( @@ -912,7 +910,7 @@ final class TeraRemoteQualificationUITests: XCTestCase { } @MainActor - private func beginDraft(_ app: XCUIApplication, type: String) throws { + func beginDraft(_ app: XCUIApplication, type: String) throws { guard openAdd(app) != nil else { XCTFail("The Add bottom tab did not present the real Add store") throw QualificationError.missingProductSurface @@ -971,7 +969,7 @@ final class TeraRemoteQualificationUITests: XCTestCase { } @MainActor - private func submitSuccessfully(_ app: XCUIApplication) throws { + func submitSuccessfully(_ app: XCUIApplication) throws { guard let submit = readySubmit(app), let value = submitAndWait(app, submit: submit) else { diff --git a/TeraUITests/TeraValidationRecoveryUI.swift b/TeraUITests/TeraValidationRecoveryUI.swift @@ -0,0 +1,17 @@ +import XCTest + +extension TeraRemoteQualificationUITests { + @MainActor + func recoverRejectedEvent(_ app: XCUIApplication, content: XCUIElement, marker: String, failure: String) throws { + XCTAssertTrue(failure.contains("Error code")) + scrollTo(app, element: content) + XCTAssertEqual(content.value as? String, marker) + XCTAssertTrue(failure.contains("event_title_required")) + XCTAssertTrue(failure.contains("Original request retained")) + let identifier = content.identifier + // Corrected editing is a new explicit request, never a mutation of the + // already reserved command and composer revision rejected above. + try beginDraft(app, type: "Event") + try enterText(app, identifier: identifier, value: marker) + } +} diff --git a/project.yml b/project.yml @@ -202,6 +202,7 @@ targets: - path: TeraUITests/TeraRemoteQualificationUITests.swift - path: TeraUITests/TeraSettingsIdentityUI.swift - path: TeraUITests/TeraAddViewportUI.swift + - path: TeraUITests/TeraValidationRecoveryUI.swift - path: TeraUITests/TeraSubmissionQualificationSupport.swift - path: test-fixtures/local-social-personas.v1.json buildPhase: resources diff --git a/release/provenance.json b/release/provenance.json @@ -6,7 +6,7 @@ "info_plist_sha256": "b55010dd73b34bf5ad910a888be0ea1ae45f2a5c14329fa6a57059a317bdbd42", "privacy_manifest_sha256": "0f2103257ba596fbcaeb1d6a4dffe3ae021e84c010178852c6bf500a8cfb0f19", "sbom_sha256": "f0a15c2c9ad7799539fbc52fd1fdbcf17f4046b6f86cfe0a9b8980adc0079e10", - "xcode_project_sha256": "8c10bd4b87d8d02a06e7d212b7da75738bc46c29316156424feb2a7c61521af1" + "xcode_project_sha256": "4e73d5c72c87b67f3974f1bd50758309fababad5d6867fbb4ea2004208b7e204" }, "disposition": "unsigned", "platforms": [ diff --git a/test-fixtures/maintainability-baseline.v1.json b/test-fixtures/maintainability-baseline.v1.json @@ -38,7 +38,7 @@ }, { "path": "TeraUITests/TeraRemoteQualificationUITests.swift", - "maximum_lines": 1956 + "maximum_lines": 1954 } ], "python_file_exception": [ diff --git a/test-fixtures/swiftlint-maintainability-baseline.v1.json b/test-fixtures/swiftlint-maintainability-baseline.v1.json @@ -1 +1 @@ -[{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":21,"file":"Tera\/App\/TeraAppModel.swift"},"reason":"Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" init("},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":31,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 373 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraGeneratedRuntimeBackend: TeraRuntimeBackend, @unchecked Sendable {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1089,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"},"reason":"File should contain 1000 lines or less: currently contains 1089","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":3,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 675 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor TeraRuntimeClient {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":353,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 70 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func changes(bufferCapacity: Int = 16) async throws -> AsyncStream<TeraRuntimeChange> {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":749,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"},"reason":"File should contain 400 lines or less: currently contains 749","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1029,"file":"Tera\/Runtime\/TeraRuntimeModels.swift"},"reason":"File should contain 1000 lines or less: currently contains 1029","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":4,"file":"Tera\/State\/TeraAddStore.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 481 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraAddStore: ObservableObject {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":702,"file":"Tera\/State\/TeraAddStore.swift"},"reason":"File should contain 400 lines or less: currently contains 702","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":78,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 468 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor TeraConfigurationStore {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"error","location":{"character":5,"line":148,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"Function body should span 100 lines or less excluding comments and whitespace: currently spans 109 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func load() throws -> TeraAppConfiguration {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":759,"file":"Tera\/State\/TeraConfigurationStore.swift"},"reason":"File should contain 400 lines or less: currently contains 759","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Complexity of function bodies should be limited.","severity":"warning","location":{"character":11,"line":96,"file":"Tera\/State\/TeraSessionStore.swift"},"reason":"Function should have complexity 10 or less; currently complexity is 13","ruleName":"Cyclomatic Complexity","ruleIdentifier":"cyclomatic_complexity"},"text":" private func start(acceptingReconfiguration: Bool) async -> TeraSessionPhase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":6,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 607 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraAddStoreTests: XCTestCase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":1,"line":682,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 394 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"actor AddBackend: TeraRuntimeBackend {"},{"violation":{"ruleDescription":"Number of function parameters should be low.","severity":"warning","location":{"character":3,"line":1020,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"Function should have 5 parameters or less: it currently has 8","ruleName":"Function Parameter Count","ruleIdentifier":"function_parameter_count"},"text":" func makeStatus("},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1232,"file":"TeraTests\/TeraAddStoreTests.swift"},"reason":"File should contain 1000 lines or less: currently contains 1232","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"warning","location":{"character":7,"line":7,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRemoteQualificationTests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":45,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 94 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testQualificationRejectsAmbiguousOrUnsafeHarnessValues() {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":212,"file":"TeraTests\/TeraRemoteQualificationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testAuthorizationEvidenceIsRedactedEphemeralAndRelaunchCleaned() throws {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"warning","location":{"character":7,"line":4,"file":"TeraTests\/TeraRuntimeClientTests.swift"},"reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 298 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRuntimeClientTests: XCTestCase {"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":6,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 580 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraStateMigrationTests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":5,"line":7,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 61 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testRelayValidationMatchesRuntimeProfiles() throws {"},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"warning","location":{"character":1,"line":622,"file":"TeraTests\/TeraStateMigrationTests.swift"},"reason":"File should contain 400 lines or less: currently contains 622","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"},{"violation":{"ruleDescription":"Type bodies should not span too many lines","severity":"error","location":{"character":7,"line":4,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 1251 lines","ruleName":"Type Body Length","ruleIdentifier":"type_body_length"},"text":"final class TeraRemoteQualificationUITests: XCTestCase {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":62,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 65 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testLocalSocialFiveFlowScenario() throws {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":166,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 66 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testLocalSocialDeterministicPersonas() throws {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":3,"line":239,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" func testRemoteBlossomUploadAndRecovery() throws {"},{"violation":{"ruleDescription":"Complexity of function bodies should be limited.","severity":"warning","location":{"character":11,"line":494,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function should have complexity 10 or less; currently complexity is 18","ruleName":"Cyclomatic Complexity","ruleIdentifier":"cyclomatic_complexity"},"text":" private func expectedAddFieldLabel(_ identifier: String, type: String) -> String {"},{"violation":{"ruleDescription":"Function bodies should not span too many lines","severity":"warning","location":{"character":10,"line":1480,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 67 lines","ruleName":"Function Body Length","ruleIdentifier":"function_body_length"},"text":" static func environment("},{"violation":{"ruleDescription":"Files should not span too many lines.","severity":"error","location":{"character":1,"line":1956,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"},"reason":"File should contain 1000 lines or less: currently contains 1956","ruleName":"File Length","ruleIdentifier":"file_length"},"text":"}"}] -\ No newline at end of file +[{"text":" init(","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines","severity":"warning","location":{"line":21,"character":3,"file":"Tera\/App\/TeraAppModel.swift"}}},{"text":"final class TeraGeneratedRuntimeBackend: TeraRuntimeBackend, @unchecked Sendable {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 373 lines","severity":"error","location":{"line":31,"character":7,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 1000 lines or less: currently contains 1089","severity":"error","location":{"line":1089,"character":1,"file":"Tera\/Runtime\/TeraGeneratedRuntimeBackend.swift"}}},{"text":"actor TeraRuntimeClient {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 675 lines","severity":"error","location":{"line":3,"character":1,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"}}},{"text":" func changes(bufferCapacity: Int = 16) async throws -> AsyncStream<TeraRuntimeChange> {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 70 lines","severity":"warning","location":{"line":353,"character":3,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 400 lines or less: currently contains 749","severity":"warning","location":{"line":749,"character":1,"file":"Tera\/Runtime\/TeraRuntimeClient.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 1000 lines or less: currently contains 1029","severity":"error","location":{"line":1029,"character":1,"file":"Tera\/Runtime\/TeraRuntimeModels.swift"}}},{"text":"final class TeraAddStore: ObservableObject {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 481 lines","severity":"error","location":{"line":4,"character":7,"file":"Tera\/State\/TeraAddStore.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 400 lines or less: currently contains 702","severity":"warning","location":{"line":702,"character":1,"file":"Tera\/State\/TeraAddStore.swift"}}},{"text":"actor TeraConfigurationStore {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 468 lines","severity":"error","location":{"line":78,"character":1,"file":"Tera\/State\/TeraConfigurationStore.swift"}}},{"text":" func load() throws -> TeraAppConfiguration {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 100 lines or less excluding comments and whitespace: currently spans 109 lines","severity":"error","location":{"line":148,"character":5,"file":"Tera\/State\/TeraConfigurationStore.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 400 lines or less: currently contains 759","severity":"warning","location":{"line":759,"character":1,"file":"Tera\/State\/TeraConfigurationStore.swift"}}},{"text":" private func start(acceptingReconfiguration: Bool) async -> TeraSessionPhase {","violation":{"ruleIdentifier":"cyclomatic_complexity","ruleDescription":"Complexity of function bodies should be limited.","ruleName":"Cyclomatic Complexity","reason":"Function should have complexity 10 or less; currently complexity is 13","severity":"warning","location":{"line":96,"character":11,"file":"Tera\/State\/TeraSessionStore.swift"}}},{"text":"final class TeraAddStoreTests: XCTestCase {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 607 lines","severity":"error","location":{"line":6,"character":7,"file":"TeraTests\/TeraAddStoreTests.swift"}}},{"text":"actor AddBackend: TeraRuntimeBackend {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Actor body should span 350 lines or less excluding comments and whitespace: currently spans 394 lines","severity":"error","location":{"line":682,"character":1,"file":"TeraTests\/TeraAddStoreTests.swift"}}},{"text":" func makeStatus(","violation":{"ruleIdentifier":"function_parameter_count","ruleDescription":"Number of function parameters should be low.","ruleName":"Function Parameter Count","reason":"Function should have 5 parameters or less: it currently has 8","severity":"warning","location":{"line":1020,"character":3,"file":"TeraTests\/TeraAddStoreTests.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 1000 lines or less: currently contains 1232","severity":"error","location":{"line":1232,"character":1,"file":"TeraTests\/TeraAddStoreTests.swift"}}},{"text":"final class TeraRemoteQualificationTests: XCTestCase {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines","severity":"warning","location":{"line":7,"character":7,"file":"TeraTests\/TeraRemoteQualificationTests.swift"}}},{"text":" func testQualificationRejectsAmbiguousOrUnsafeHarnessValues() {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 94 lines","severity":"warning","location":{"line":45,"character":3,"file":"TeraTests\/TeraRemoteQualificationTests.swift"}}},{"text":" func testAuthorizationEvidenceIsRedactedEphemeralAndRelaunchCleaned() throws {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines","severity":"warning","location":{"line":212,"character":3,"file":"TeraTests\/TeraRemoteQualificationTests.swift"}}},{"text":"final class TeraRuntimeClientTests: XCTestCase {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 250 lines or less excluding comments and whitespace: currently spans 298 lines","severity":"warning","location":{"line":4,"character":7,"file":"TeraTests\/TeraRuntimeClientTests.swift"}}},{"text":"final class TeraStateMigrationTests: XCTestCase {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 580 lines","severity":"error","location":{"line":6,"character":7,"file":"TeraTests\/TeraStateMigrationTests.swift"}}},{"text":" func testRelayValidationMatchesRuntimeProfiles() throws {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 61 lines","severity":"warning","location":{"line":7,"character":5,"file":"TeraTests\/TeraStateMigrationTests.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 400 lines or less: currently contains 622","severity":"warning","location":{"line":622,"character":1,"file":"TeraTests\/TeraStateMigrationTests.swift"}}},{"text":"final class TeraRemoteQualificationUITests: XCTestCase {","violation":{"ruleIdentifier":"type_body_length","ruleDescription":"Type bodies should not span too many lines","ruleName":"Type Body Length","reason":"Class body should span 350 lines or less excluding comments and whitespace: currently spans 1249 lines","severity":"error","location":{"line":4,"character":7,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":" func testLocalSocialFiveFlowScenario() throws {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 65 lines","severity":"warning","location":{"line":62,"character":3,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":" func testLocalSocialDeterministicPersonas() throws {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 66 lines","severity":"warning","location":{"line":166,"character":3,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":" func testRemoteBlossomUploadAndRecovery() throws {","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines","severity":"warning","location":{"line":239,"character":3,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":" private func expectedAddFieldLabel(_ identifier: String, type: String) -> String {","violation":{"ruleIdentifier":"cyclomatic_complexity","ruleDescription":"Complexity of function bodies should be limited.","ruleName":"Cyclomatic Complexity","reason":"Function should have complexity 10 or less; currently complexity is 18","severity":"warning","location":{"line":494,"character":11,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":" static func environment(","violation":{"ruleIdentifier":"function_body_length","ruleDescription":"Function bodies should not span too many lines","ruleName":"Function Body Length","reason":"Function body should span 50 lines or less excluding comments and whitespace: currently spans 67 lines","severity":"warning","location":{"line":1478,"character":10,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}},{"text":"}","violation":{"ruleIdentifier":"file_length","ruleDescription":"Files should not span too many lines.","ruleName":"File Length","reason":"File should contain 1000 lines or less: currently contains 1954","severity":"error","location":{"line":1954,"character":1,"file":"TeraUITests\/TeraRemoteQualificationUITests.swift"}}}] +\ No newline at end of file